Minres / CoreDSL

Xtext project to parse CoreDSL files
Apache License 2.0
16 stars 3 forks source link

CoreDslScopeProvider Rewrite #61

Closed AtomCrafty closed 2 years ago

AtomCrafty commented 2 years ago

Completely rewrites com.minres.coredsl.scoping.CoreDslScopeProvider from scratch.

Model changes:

Currently supported tasks:

I assumed enum members should be scoped the same way as in C, so they are simply added to the global ISA scope as constants.

@eyck is it possible to disable generation of CoreDslScopeProvider.java when the mwe2 workflow is run? The implementation is located in an .xtend file, but the .java file is regererated anyway. I believe you previously solved this by moving the actual implementation to XtCoreDslScopeProvider.xtend and subclassing the auto-generated class, but that feels like an ugly hack. Fixed it by providing an empty stub file myself. Not the prettiest solution, but still better than before.

jopperm commented 2 years ago

@eyck Does the model change affect you or can this PR just land?

eyck commented 2 years ago

@eyck Does the model change affect you or can this PR just land?

No, there is no problem integrating this.