Minres / CoreDSL

Xtext project to parse CoreDSL files
Apache License 2.0
14 stars 2 forks source link

Minor specification fixes #88

Closed jopperm closed 1 year ago

jopperm commented 1 year ago
jopperm commented 1 year ago

Diff

AtomCrafty commented 1 year ago

Regarding sizeof: There is an extra closing parenthesis in the definition ⌈bitsizeof(T)/8⌉). Personally, I find the ceiling brackets to be pretty difficult to see, so I would suggest replacing the definition by ceil(bitsizeof(T)/8) or (bitsizeof(T) + 7) / 8.

Both sizeof and bitsizeof also accept arbitrary expressions, returning the size of the expression's analyzed type.

jopperm commented 1 year ago

Thanks, fixed.