search

Mint-System / Odoo-Apps-Sale-Workflow

Collection of sale model related modules.
2 stars 3 forks source link

15.0 sale_order_line_not_billable #2

Open leemannd opened 8 months ago

leemannd commented 8 months ago

Hello @janikvonrotz @dbruehlmeier , I saw the work you did on the module sale_order_line_not_billable.

We are currently interested in using it in 15.0. As you are the author of the modules. I would like to know if it is ok for you if I can port it to 15.0 and add it to an OCA repository. There is only one issue doing so, the license. The OCA is favoring the the AGPL-3 and your module is currently under the GPL-3.

Is it ok for you if I:

janikvonrotz commented 8 months ago

Hi @leemannd

I welcome any kind of help to migrate the modules to OCA.

Feel free to update the license. It would be nice to keep "Mint System GmbH" as the author in the manifest. Last, can you add me and yourself to the contributor.md?

Note: I am not familiar on how to get the module to the OCA repo. I always had it in mind that Mint System modules should be move to OCA, however, I lack the resources to execute this plan. Can you @ in the PR so I can learn (maybe it is not that much of a deal)?

janikvonrotz commented 8 months ago

@dbruehlmeier I assume you were mentioned because of you contributions to the repo. @leemannd works at camp2camp and camp2camp is heavenly involved with the OCA.

leemannd commented 8 months ago

Hello, thank you for the quick answer. I will respect the history and authorship of the module.

When done I will come back here to ask you for a review. A first draft should be done in between this week and next week. AFAIR the OCA runbot is checking if the users have signed the OCA cla? Is it the case for your github user?

By checking the git history, I may change the authorship of one commit from "mitchell admin" to your user -> https://github.com/Mint-System/Odoo-Apps-Sale-Workflow/commits/14.0/sale_order_line_not_billable

janikvonrotz commented 8 months ago

Yes, I signed the OCA cla.

Thank you very much!

janikvonrotz commented 8 months ago

You can also squash the commits, afaik it is sometimes required by the repo maintainer.

dbruehlmeier commented 8 months ago

Hi @leemannd! Thank you very much for this initaitive and fully support the backport and the move to OCA. 👍