search

Mint-System / Odoo-Apps-Server-Tools

Collection of Odoo apps to improve technical features.
10 stars 10 forks source link

Add default Prometheus process Metrics #3

Open dirsigler opened 2 months ago

dirsigler commented 2 months ago

Hello everyone,

we just added the Prometheus Exporter to our own Odoo deployment to get additional observability of the system. I was kinda confused to find out, that the Prometheus Exporter only provides the 3 custom metrics and ignores default values about the process CPU and Memory usage. As explained here on the Prometheus Python Client SDK these metrics are provided out of the box: https://prometheus.github.io/client_python/getting-started/three-step-demo/

Is there any objection to add these default metrics to the Prometheus Exporter?

janikvonrotz commented 2 months ago

@dirsigler Thanks for the input. I don't have any objections. Can you create a PR?

janikvonrotz commented 2 months ago

@dirsigler I guess host metrics (ram, cpu, disk) should not be added. They are usually expose with node_exporter or cadvisor. But request time would be great!

janikvonrotz commented 2 months ago

This might require an new type of metric called python expression.