MintyTrebor / ReleaseMgr

DWC Plugin to assist with upgrading RRF firmware
GNU General Public License v3.0
8 stars 0 forks source link

Suggestion to expand matching rules #3

Closed dc42 closed 2 years ago

dc42 commented 2 years ago

Please can the matching rules be extended so that a tag of the form [A + B] will be matched whenever the tag [A] would be matched. For example:

[Duet 3 Mini + SBC] would be highlighted if the user is running a Duet 3 Mini [Duet 3 + expansion boards] would be highlighted if the user is running any Duet 3 main board

These are examples from the current RRF 3.4.2 release note. I am not aware of an alternative way of expressing them that would be recognised by ReleaseMgr.

MintyTrebor commented 2 years ago

Under the current ruleset [Duet 3 Mini + SBC] would only be matched when the user has both a Duet 3 Mini AND and SBC, if you want it to work on an OR condition, the syntax would be [Duet 3 Mini][SBC]. See here for explanation of the conditionality syntax.

I have updated the dataset to match [Duet 3 + expansion boards]

dc42 commented 2 years ago

Thanks, that matching rule is good. I suppose what I really wanted was that if there is a tag [A + B] but ReleaseMgr does not understand tag B, it would ignore the "+ B" part and match if tag A is matched.

MintyTrebor commented 2 years ago

I can see if I can change it to ignore rnNames that do not exist in the dataset, however that still would not work in your example as SBC is defined in the dataset.

dc42 commented 2 years ago

That's fine, my example was wrong and [Duet3 Mini + SBC] works correctly according to your description (I didn't test that example). I think I made my original report because I used [Duet 3 + expansion boards] and ReleaseMgr didn't recognise "expansion boards" so it didn't flag it as being relevant to my system.