Miq1 / FredBoard

Alternative firmware development for THY333
MIT License
1 stars 0 forks source link

Flickering LEDs are back. #20

Closed Smelter closed 4 weeks ago

Smelter commented 1 month ago

Version

alpha5

What is the issue?

These are LEDs on the Left Hand End under the 'C' label. Looks like a retro step as all was well with 4g.

https://github.com/user-attachments/assets/8d77b9f2-49b6-4f30-bab1-952cadc8f248

amaskell999 commented 1 month ago

I think this has been fixed in alpha5.1.A

Smelter commented 4 weeks ago

I think this has been fixed in alpha5.1.A

I would agree if it wasn't for the fact that if you roll over on the noise menu and get to zero it is back. Extreme case, but is the install default value, higher than single digit to avoid this?

Miq1 commented 4 weeks ago

Does rather look like the DMA quirk is back Fred had earlier.

Frudah commented 4 weeks ago

If you reset your settings on install of the new firmware I believe the default is 40 for noise floor. I can make the lower limit higher for roll over… or assign it to a sub menu so it allows up and down so there is no roll over. 5.1.a does fix it I believe. The buffer function is still the same. I plan on improving it. What I did find, was the strummer1 was always active and cycling and it was lagging down the led timing.

I have now made it so the strummer isn’t activated until a button with strum is pressed and is deactivated after a press. I’m sure I can optimize the strummer a bit to not make it as resource intensive later.

Frudah commented 4 weeks ago

… and closed

Frudah commented 3 weeks ago

I also found that strummer 2 and strummer 3 modules were continually looking to make sure there were no unresolved strum notes to turn off, robbing the chip of thousands of clock cycles per midi pulse. 5.2 has this fixed and should further reduce any of these erroneous pulses being presented.