Gifted and incompetent skills in GUI - Githubissues

MirUlr / dsa_calculator

Some classes for handling the 3d20 test of the the german pen and paper system in a streamlined way.

Creative Commons Zero v1.0 Universal

0 stars 0 forks source link

Gifted and incompetent skills in GUI #15

Closed MirUlr closed 3 years ago

MirUlr commented 3 years ago

Class Hero provide automatical management of Begabungen and Unfähigkeiten, if they were specified correctly. Methods get_gifted_skills_gui() and get_incompetent_skills_gui() provide possibility to process these information in graphical user interface.

It is hereby proposed to use checkboxes for marking a roll on an skill/spell-like as gifted. This proposal is motivated by the circumstance, that the effect of gifted also be caused by several mechanics, e.g. Stärkungssegen or Weisheitssegen.

Summarized behavior:

Every skill or spell-like provide a checkbox to mark it as gifted
After execution of the test, the correspondig checkbox is unchecked
Inherent gifted skills (see Held.get_gifted_skills_gui()) are ckeckd as default and can not be unchecked by user
Inherent gifted skills are not unchecked after execution of test

MirUlr commented 3 years ago

@Ithiliel What is your opinon on this?

MirUlr commented 3 years ago

@MirUlr Held.absolviere(talent, modifikator) shall be extened by keyword argument for those temporal gifted talents.

RabeaSennlaub commented 3 years ago

The functionality sounds good. Maybe the GUI Layout needs to get adjusted, so it will not be to crowded with yet another column.

MirUlr commented 3 years ago

After revisitng the rulebook it seems unnecessary to implement the concept of temporal gifted/incompetent skills.

Reason: All (at least most) events, which cause the temporal gifted effect, need the player to confirm the reroll (and also to pick the specific dice). Therefore the user need to be asked, whether or not the effect of gifted shall be used. This would raise the need to rework Hero in an extensive way; e.g. remember the past (and only this) roll. On the other hand, the operation of such a multi-stage-dialogue for one roll is not intuitive.

Therefore the objective of this issue changes to the implementation of the possibility to state skills and spell-likes as gifted and incompetnet in makeHero.py. Further these permanent affected abilities should be vizually marked in GUI.py.

MirUlr commented 3 years ago

Closed du to creating of #31 and push of bcb597b