search

MiraWaNeko / DiscordIntegration

Communicate between Minecraft and Discord
https://discordintegration.net
GNU Affero General Public License v3.0
88 stars 42 forks source link

No achievements (advancements) being relayed to discord #126

Closed Ricket closed 6 years ago

Ricket commented 6 years ago

Base informations

Minecraft version: 1.12.2

Modpack: FTB Revelation 1.3.0

DiscordIntegration version: DiscordIntegration-mc1.12.2-3.0.4.jar

Link to pastebin with (censored) config: https://pastebin.com/4C8GRYUq

Expected behavior

Advancements should be relayed to discord

Actual behavior

No advancements since the start of our server have been sent to our discord channel. We have gained various advancements and have also had lots of chat messages, logins/outs, and deaths that have successfully been relayed. relayAchievements is set to true (see the pastebin'd config).

Steps to reproduce

Ricket commented 6 years ago

Huh, looks like it's just totally commented out, probably due to "achievement"->"advancement": https://github.com/Chikachi/DiscordIntegration/blob/f0686253ab710fdb458ab2b91f0725f8265a3f1a/src/main/java/chikachi/discord/listener/MinecraftListener.java#L261-L318

MiraWaNeko commented 6 years ago

There were no event for advancements at the time that code got written.

Ricket commented 6 years ago

Thanks for the quick fix :+1:

Ricket commented 6 years ago

I built the mod and verified your fix. Only thing is the config file still references "achievements". You may want to rename those keys and messages.

Muzarmo commented 6 years ago

Hi! Is this fix being integrated into a new version?

Kind regards

MiraWaNeko commented 6 years ago

3.0.5 released with the fix