search

Miraak7000 / AssetViewer

GNU General Public License v3.0
120 stars 22 forks source link

Please sort Expedition Events by name #24

Closed corgatag closed 4 years ago

corgatag commented 4 years ago

Hi,

Could you sort Expedition Events by name? I tried to create a small feature branch with this 2-line change, but got a 403.

ExpeditionEvents.xaml.cs line 31

var document = XDocument.Parse(reader.ReadToEnd()).Root; var items = document.Elements().Select(s => s.FromXElement<ExpeditionEvent>()).OrderBy(item => item.Name.CurrentLang); foreach (var item in items) { Events.Add(item); }

Thanks!

ExpeditionEvents.xaml.cs.txt

Veraatversus commented 4 years ago

The expedition events has to be reworked anyway. There are not all posible ways for the id's listed. Your solution isn't really good because the different possible languages. It would only be sorted by start language. I have planed to rework this soon and I will implement a feature like this. Thanks for report.

Veraatversus commented 4 years ago

plan has changed. its implemented in a similar way until the rework. does not resort after language changed. it will be in the next release with update 7 or now under https://drive.google.com/open?id=1N5AUPYDhhluKMLPEMvF45qsUs27ed6Cg