MiraculixxT / bluemap-banner

A BlueMap addtion. Give your players the opportunity to create their own live markers on BlueMap via an vanilla features. Banners!
GNU General Public License v3.0
6 stars 2 forks source link

never add markers while sneaking #3

Closed RealMuffinTime closed 10 months ago

RealMuffinTime commented 1 year ago

Currently you can place a banner while sneaking, when the player is at a marker limit, without adding a marker to the map.

I think it would be nice, that when you sneak, there will never be a marker created.

MiraculixxT commented 1 year ago

Yeah, that could be easily implemented. I'll note it down for the next release

MiraculixxT commented 1 year ago

Hey, while adding your idea, i was thinking about sneaking while placing. Isn't sneaking to place a banner a very common thing, because some places dont allow placing it without?

Do you think it would annoy more then help and #2 is maybe a better approach?

RealMuffinTime commented 1 year ago

Yeah, I also thought about that, but I think mostly you place banners onto blocks which are not interactable?

Maybe a setting regarding that behavior would be a solution. Or always when sneaking there is a message, which tells the player no marker has been added, because the player sneaked. (Maybe, I don't know the effort it would need, add a clickable command to the message to allow sneaking and placing temporarily.)

Basically it doesn't need to be sneaking to achieve no adding, but it would be nice to have some easy way to not add markers, while placing banners.

But the blacklist would be server wide, and not customisable for an individual player, or?

MiraculixxT commented 10 months ago

Sooo, i added it finaly :) (a bit late, sorry for that) I decide to make it configurable inside the config, whether sneaking should be ignored or not. Together with the custom blocked names list i hope it works for you!

Update is downloadable on Modrinth now, you might need to delete your settings.yml.

RealMuffinTime commented 10 months ago

Perfect.