search

Mirai-Team / mirai-project

C++ library for games making purposes.
Other
3 stars 0 forks source link

Update base encryption #52

Closed Lomadriel closed 9 years ago

Lomadriel commented 9 years ago

In encryption class, I think it's better to use (unsigned char*) instead std::string, indeed char is one byte type. Moreover hold a pointer is better than hold the whole file

Lomadriel commented 9 years ago

See #66

Lomadriel commented 9 years ago

I think we should also remove boost::filesystem from MP before accept the pr #66. It's quite easy to remove it since we just list all the files in the given directory.

CBenoit commented 9 years ago

Yes, so users no longer needs to have boost::filesystem, if he's not interested in it.

Lomadriel commented 9 years ago

See #79

Lomadriel commented 9 years ago

Since the Archiver + basic encryption functions were accepted, I close this issue.