Mirai-Team / mirai-project

C++ library for games making purposes.
Other
3 stars 0 forks source link

Taking into account new norms. #67

Open CBenoit opened 9 years ago

CBenoit commented 9 years ago

I updated norms in enhancement/norms branch. When all issues for MiraiProject V0.3 are closed, let's merge all in this branch and perform a big code clean up !

Lomadriel commented 9 years ago

Maybe should we add this:

Example:

class ParentClass
{
    public:
        void update();
};
class DaughterClass : ParentClass
{
    public:
        void update() override;

};
CBenoit commented 9 years ago

That's a good idea. I'm going to add that.

Lomadriel commented 9 years ago

Done. Sorry I didn't notice your answer before committing .

Lomadriel commented 9 years ago

Should we require the users to mark constructors that are callable with a single argument to be explicit ?

Lomadriel commented 9 years ago

Use std::move when you no longer need the arguments. See http://blog.smartbear.com/c-plus-plus/c11-tutorial-introducing-the-move-constructor-and-the-move-assignment-operator/

CBenoit commented 9 years ago

Good idea. I added these in following commits : https://github.com/Mirai-Team/mirai-project/commit/64c801958d9e49e72b518e2164e666e0e5c6afae and https://github.com/Mirai-Team/mirai-project/commit/b6f7bc995f721020d6d1fe6ab28b30ed7a9b2fd5