search

Mirantis / cri-dockerd

dockerd as a compliant Container Runtime Interface for Kubernetes
https://mirantis.github.io/cri-dockerd/
Apache License 2.0
1.12k stars 292 forks source link

Drop the support for CRI v1alpha2 #333

Open AkihiroSuda opened 8 months ago

AkihiroSuda commented 8 months ago

https://github.com/Mirantis/cri-dockerd/blob/9a8a9fe300c829ed292d4bb97d8626c3077f6b25/core/service_alpha.go#L25

Kubernetes has dropped the support for CRI v1alpha2 in Kubernetes v1.26:

v1.25, the last release to support v1alpha2, has already reached the EOL: https://kubernetes.io/releases/patch-releases/#non-active-branch-history

So I guess cri-dockerd should be ready to drop it too?

afbjorklund commented 8 months ago

As long as it is documented (and something like 0.4?), I think the feature can be removed also from cri-dockerd...

Previously the versioning of tools like crictl was unclear, and thus many tried to use them with e.g. new containerd and failing. But now the release of cri-tools and cni-plugins has been bundled with the kubeadm installation, so that users need to upgrade their CRI and CNI with their k8s installation. There was already the issue of cri-dockerd not supporting k8s versions before 1.24, where dockershim should be used instead. But I think* 1.24-1.26 should support CRI v1?

* looking at for instance the https://containerd.io/releases/#kubernetes-support table, where it says "1.23+"

https://kubernetes.io/blog/2021/12/07/kubernetes-1-23-release-announcement/#container-runtime-interface-cri-v1-is-default