search

Mirantis / launchpad

Other
27 stars 45 forks source link

Adapt Azure TF example to use yamlencode #58

Closed kke closed 3 years ago

kke commented 3 years ago

Makes the azure example from #53 utilize the yamlencode from #57

Also adds a note about rebooting windows hosts until 1.1 is out.

stevejr commented 3 years ago

@kke - Can you add the file examples/terraform/README.md to the PR as it needs to be updated story state that Azure examples are available. Other than that it looks good

kke commented 3 years ago

@kke - Can you add the file examples/terraform/README.md to the PR as it needs to be updated story state that Azure examples are available. Other than that it looks good

Added. Also noticed that OpenStack was missing and some of the examples still stated yq needs to be installed.

stevejr commented 3 years ago

@kke - Do we need to highlight anywhere that the examples, at least the Azure Terraform one, does not setup any DTR related infra?

kke commented 3 years ago

@kke - Do we need to highlight anywhere that the examples, at least the Azure Terraform one, does not setup any DTR related infra?

Seems like none of them do. We can add those in later, I think this one is good to go.