Mirantis / virtlet

Kubernetes CRI implementation for running VM workloads
Apache License 2.0
741 stars 128 forks source link

support building virtlet with myself vendor or "glide install" #829

Closed volume-ji closed 5 years ago

volume-ji commented 5 years ago

I want to build Mirantis/virtlet:latest with myself vendor other than "glide install" because it looks like downloading many useless package. So I submit this pr.

two point:

  1. delete a filter about local vendor
  2. add code logic to adapt myself vendor or "glide install" by environment "VIRTLET_SKIP_VENDOR"

dear @jellonek , do you agree with me?


This change is Reviewable

volume-ji commented 5 years ago

./sig test

jellonek commented 5 years ago

Still branch is not building on CI.

jellonek commented 5 years ago

You need to rebase on top of master to fix the current issue with building tests on CI.

jellonek commented 5 years ago

Ping.

volume-ji commented 5 years ago

rebase to new version