It is not a good option to remove container if start container failed. The comments:
// FIXME: we do this here because kubelet may attempt new `CreateContainer()` // calls for this VM after failed `StartContainer()` without first removing it.
To remove container, the domain and VM will be removed too, it will impact running VMs, all data of running VM may be lost. For example, if the disk is full, the VM will get into paused state, and you cannot start the domain, but we should not remove the VM to workaround the problem.
It is not a good option to remove container if start container failed. The comments:
// FIXME: we do this here because kubelet may attempt new `CreateContainer()` // calls for this VM after failed `StartContainer()` without first removing it.Even kubelet may attempt new
CreateContainer(), the virtlet will do nothing as the container has already been in db: https://github.com/Mirantis/virtlet/blob/master/pkg/manager/runtime.go#L305To remove container, the domain and VM will be removed too, it will impact running VMs, all data of running VM may be lost. For example, if the disk is full, the VM will get into paused state, and you cannot start the domain, but we should not remove the VM to workaround the problem.
This change is