search

Mirantis / virtlet

Kubernetes CRI implementation for running VM workloads
Apache License 2.0
743 stars 128 forks source link

Fix demo.sh for MULTI_CNI #889

Closed GregoryVds closed 5 years ago

GregoryVds commented 5 years ago

As demo::install-cri-proxy() causes a restart of the pods, it should be done before demo::install-cni-genie(). Otherwise the modifications done by demo::jq-patch() to /etc/cni/net.d get overwritten.

Signed-off-by: Gregory Vander Schueren gregory.vanderschueren@tessares.net

Also, I noticed the MULTI_CNI demo runs with a single host. Is there any reason not to run it with 2 hosts like the regular demo? I would be interested in modifying it to have 2 hosts. Will I run into troubles if I do so? Thanks.

This change is Reviewable

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

jellonek commented 5 years ago

@pigmej @ivan4th PTAL and merge or reopen that.