search

Mirantis / virtlet

Kubernetes CRI implementation for running VM workloads
Apache License 2.0
739 stars 128 forks source link

Enable qat vf device support by pci-passthrough in Virtlet vm #915

Closed leyao-daily closed 4 years ago

leyao-daily commented 4 years ago

I found gap that virtlet will consider all the devices declared in pod yaml except cpu and memory as volume device.

And to enable the qat vf device assigned to VMs, I change the basic libvirt domain xml file and pass through the vf device to VM.

This change is Reviewable

jellonek commented 4 years ago

Can you squeeze all these commits to a single one?

leyao-daily commented 4 years ago

And I have squeezed all these commits into one. Thanks.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

leyao-daily commented 4 years ago

Tests with zero and one more qat vfs are all passed.

leyao-daily commented 4 years ago

Hi, if I want to deliver a variable to /cmd/vmwrapper/vmwrapper.go how should do. Is there any api for vmwrapper to get a variable from virtlet runtime.

jellonek commented 4 years ago

You need to add it somewhere around https://github.com/Mirantis/virtlet/blob/96a0d1f6fbc00903ad616f22926b852bdf5be5da/pkg/libvirttools/virtualization.go#L147

leyao-daily commented 4 years ago

Hi, is there anything wrong with the ci-tests? I found that even the source code from mirantis/virtlet-master cannot pass the ci-tests.

leyao-daily commented 4 years ago

@jellonek @pigmej Is there anything wrong with the CI/test? Even the official source code can not pass it now. And is there any advices to push this PR? We need utilize it in Akraino/ICN bp.

jellonek commented 4 years ago

Sorry but I don't have rights to fix anything in this project anymore, as I changed companies long time ago, and looks like Mirantis abandoned this project leaving it unmaintained, even if developers the team wanted to continue working on it (me including).

leyao-daily commented 4 years ago

Sorry but I don't have rights to fix anything in this project anymore, as I changed companies long time ago, and looks like Mirantis abandoned this project leaving it unmaintained, even if developers the team wanted to continue working on it (me including).

Thanks for your response. It seems that no one maintains the project now. What a pity.:(

leyao-daily commented 4 years ago

@pigmej Is Virtlet still be maintained?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.