search

Mirascope / mirascope

LLM abstractions that aren't obstructions
https://docs.mirascope.io/
MIT License
680 stars 37 forks source link

Added basic NER using prompt engineering #489

Closed KTS-o7 closed 1 week ago

KTS-o7 commented 2 weeks ago

Hello @willbakst ! I have tried some basic implementation on prompt engineering way of doing NER. There is a lot of improvements for structuring it . This is just a prototype from my side. related to our discussion at #259

Thanks in advance !

KTS-o7 commented 2 weeks ago

I have added the changes you suggested and put the files in right places in py and md formats. fixed the following

willbakst commented 2 weeks ago

I have added the changes you suggested and put the files in right places in py and md formats. fixed the following

  • groq.call used instead of groq.groq_call
  • used textwrap to indent
  • made the test cases changes
  • added simple ner and improved ner for changes.

I'm not seeing your commit, make sure to push it a re-request my review when it's ready for another look :)

KTS-o7 commented 2 weeks ago

Edit : It was some commit issue. I have resolved it and rebased it to new updates in the main dev branch. Requesting your review @willbakst

I dont know why my commits arent showing up. I will close this PR and open a fresh one again. ( thats what stackoverflow workaround said tho :( )

KTS-o7 commented 2 weeks ago

I think now it's visible for review @willbakst

KTS-o7 commented 1 week ago

@willbakst , I have made changes to the usage of pydantic models. But the validation of NER test cases is something that i didnt get any ideas for.

Would be really helpful if you guys can finish the final part and merge :) Looking forward to contribute more once I am done with semester finals.

willbakst commented 1 week ago

Would be really helpful if you guys can finish the final part and merge :)

Will do! We're a bit swamped this week, but I will aim to finish this up in time for the upcoming release so your contribution can be included :)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0300cc8) to head (748502b). Report is 8 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #489 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 318 318 Lines 9312 9312 ========================================= Hits 9312 9312 ``` | [Flag](https://app.codecov.io/gh/Mirascope/mirascope/pull/489/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mirascope) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/Mirascope/mirascope/pull/489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mirascope) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Mirascope#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.