search

MiroK / fenics_ii

MIT License
15 stars 8 forks source link

Small change to allow trace spaces on mixedelements #1

Closed andreavs closed 6 years ago

andreavs commented 6 years ago

Hi! This is a great piece of software. I am interested in using it for solving the Nernst-Planck equation for a set of ion concentrations with an EMI-like boundary. The equations are coupled and require a MixedElement-approach. This small change allows for a mixed element in my case, and should work identically in the previously implemented cases.

MiroK commented 6 years ago

Thanks for the patch! I forgot about the mixed elements/function spaces because with cbc block these would be lists of elements/spaces.

MiroK commented 6 years ago

Hi @andreavs, I was doing some cleanup which touched the mixed element traces. Does the modification work in your code?

andreavs commented 6 years ago

Hi @MiroK! I pulled the most recent commit, and it looks to me like it works. The code runs and produces the same results as it did yesterday.

MiroK commented 6 years ago

Perfect, thanks.