search

Mirobit / bitcoin-node-manager

:bar_chart: Lightweight dashboard and control system for bitcoin nodes
MIT License
122 stars 62 forks source link

Ban List Cron Job no longer working after upgrade #36

Closed mcjoshea closed 3 years ago

mcjoshea commented 3 years ago

Just realised that the ban list cron job is no longer working. I can manually run the rules and that works fine. It's just the cron jobs no longer work.

Here's the error I get when I enter the cron job into the browser manually:

Fatal error: Uncaught ArgumentCountError: Too few arguments to function App\jsonRPCClient::__construct(), 1 passed in /var/www/bitcoin/bnm/index.php on line 31 and at least 2 expected in /var/www/bitcoin/bnm/src/jsonRPCClient.php:39 Stack trace: #0 /var/www/bitcoin/bnm/index.php(31): App\jsonRPCClient->__construct('http://bitcoin:...') #1 {main} thrown in /var/www/bitcoin/bnm/src/jsonRPCClient.php on line 39

If I go back to the old version of BNM it work fine except I get the whitelist error but the job runs successfully and the appropriate nodes are blocked.

Any ideas?

Mirobit commented 3 years ago

I changed the code that makes the bitcoin core rpc call and forgot to change the cronjob part. Should be easy to fix.

Fixed in 8091688e1a8e746d59192c274abb3f4ecd65fae6

Thanks for reporting this.

mcjoshea commented 3 years ago

Thanks. All working again now.