Mirobit / bitcoin-node-manager

:bar_chart: Lightweight dashboard and control system for bitcoin nodes
MIT License
123 stars 64 forks source link

Onion node ip addresses don't display #50

Closed proofer closed 1 year ago

proofer commented 3 years ago

"Unknown" displays instead.

I have patched my copy of /src/Utility.php, first line of function checkIpPort($ip){ thus:

/bitcoin-node-manager/src$ diff Utility.php.orig Utility.php
127c127
<   if(preg_match("/^\[{0,1}[0-9a-z:\.]{7,39}\]{0,1}:[0-9]{1,5}$/", $ip)) {
---
>   if(strpos($ip, ".onion") or preg_match("/^\[{0,1}[0-9a-z:\.]{7,39}\]{0,1}:[0-9]{1,5}$/", $ip)) {
github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. With no activity this will be closed in 60 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 60 days with no activity.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. With no activity this will be closed in 60 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 60 days with no activity.

Mirobit commented 1 year ago

Thanks for pointing this out. Has been fixed (da4f362e2674aa39349d72571ce840c642b6e6a3). Please let me know if there is still an issue with this.