Mirobit / bitcoin-node-manager

:bar_chart: Lightweight dashboard and control system for bitcoin nodes
MIT License
123 stars 64 forks source link

IPv4 is displayed incorrectly when multiple addresses are available #53

Closed qertoip closed 1 year ago

qertoip commented 2 years ago

The expected behavior is to pick the IPv4 with the highest score value returned by getnetworkinfo.

It seems BNM currently simply picks random (or maybe the last) IPv4 on the list.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. With no activity this will be closed in 60 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. With no activity this will be closed in 60 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 60 days with no activity.

Mirobit commented 1 year ago

I think it was just using the last IP bitcoin core provided. This should be fixed now (d0a16c9b7c8453ff35a8a9b2a7dd72aa77cc6286). Please let me know if it works. I don't have multiple ipv4 ips to test it.