Mirreski / Skript

Skript is a Bukkit plugin which allows server admins to customize their server easily, but without the hassle of programming a plugin or asking/paying someone to program a plugin for them.
http://njol.ch/projects/skript
7 stars 2 forks source link

Fix for SQLite databases error #28

Closed piratjsk closed 9 years ago

piratjsk commented 9 years ago

Small fix for #27 and dependencies update.

Mirreski commented 9 years ago

Thanks, I am no expert at Maven, so I am a bit uncomfortable with it. Which is the reason behind me adding some(2) things directly to the classpath:p

Btw I suppose you have tested the fix with SQlite databases?

I will merge it tomorrow as I am on my way to sleep now. I will try to test it myself also but I have never setup a database lol.

Edit: Oh I saw you made a post about this on Skript.pl:)

piratjsk commented 9 years ago

Yes I tested it. The issue was calling prepareQueries() method for a first time before the table was created. This method is already called in load_i() #L189 which is executed on skript start up, so these 4 lines I removed were basically unnecessary duplication of code.

Mirreski commented 9 years ago

Okay! Thanks for helping me with these database problems!