search

Mirroar / TopFit

A World of Warcraft Addon that helps you with Equipment choices.
http://www.wowinterface.com/downloads/info16177-TopFit.html
9 stars 6 forks source link

Need to reset existing sets when new weights are published #35

Open ghost opened 10 years ago

ghost commented 10 years ago

Had some issues with friends who didn't see any benefits because they didn't manually delete their old profiles. Walked them through how to delete those, and once they did and created new sets using the new weights, things were fine.

Would suggest that we force a reset every time weights are re-calculated and also pop an alert message if possible, "Hey we reset your gear with new weights. Go fix it!"

ckaotik commented 10 years ago

This consists of two parts:

  1. regularly update the addon to include updated weights
    • I've recently discovered Noxxic's stat weights and we could probably pull from those way easier than AskMrRobot (hides all their code and weights from automatic parsing) or Wowhead (weights are often out of date and not easily accessed by code)
  2. Add versioning to created and used preset sets so we can actually tell if the set is based on a preset and inform when it updates. This could work similarly to #22.
ghost commented 10 years ago

I'm happy to take on updating a spreadsheet with Weight Sets if you would like.

I do not like Noxxic as a raider.

They are incomplete stats. Example:

AMR:

Intellect 5.25 SpellPower 4.80 Mastery 3.15 Haste 2.70 Multistrike 2.50 CriticalStrike 2.40 Versatility 2.30

Noxxic:

( Pawn: v1: "PvE-630-Mage-Arcane-Noxxic": MasteryRating=1.65, Intellect=4.01, HasteRating=1.47, CritRating=1.47, Versatility=1.28, Multistrike=1.53 )

Note how Noxxic left out Spell Power... I ran the numbers by some other folks, Noxxics aren't correct. We shouldn't use those numbers.

ghost commented 10 years ago

Confirmed... asked some theory crafters who I know if Noxxic was a good source... response back was, "Hell to the no!" Not sure why they have the values they do, but their value aren't correct.

Mirroar commented 10 years ago

I agree that something needs to be done when there is a major update to our presets. I see the following options:

  1. Delete the user's old sets and behave like a newly installed version - asking the user to create new sets.
    • I don't really like this approach because what if the user has sets that do not stem from a preset or are customized?
  2. Internally keep track of sets that still use their default weights, and update those automatically. If the user edits weights for the set, it becomes a "custom" set and no longer automatically gets updated.
    • Better than number 1, but error-prone and difficult for the user to understand.
  3. Show a window somewhat similar to what's proposed in #22, listing the user's sets and allowing them to convert each of their sets to an updated preset - or keeping them as-is.
    • This is a lot more work, but would also allow us to inform the user of stats that have been added or are no longer supported.

I'm generally against updating the user's sets without their consent unless we know for certain that these sets use our presets. But I'm open to more suggestions on how to solve this.

ghost commented 10 years ago

Funny conversation from guild chat...

[G] [NEW CASTER DPS]: Fire Mage looks like the worst DPS according to Noxxic. [G] [TRUSTED CASTER DPS]: Ah, thats why. You browse noxxic. [G] [TOP CASTER DPS]: noxxic is toxxic [G] [TOP CASTER DPS]: noxxic is literally a troll site [G] [TOP CASTER DPS]: they give out blatantly wrong information

Ran into a few people who were using Noxxic stats in PUGs. They tend to under perform.

ghost commented 10 years ago

Ha, even the Reddit casuals call out Noxxic.

http://www.reddit.com/r/wow/comments/2nqwsj/how_is_noxxic_so_popular_yet_literally_has_false/