ckaotik
commented
10 years ago The main problem with trinket prods is that they're not easily "understood" by the addon, i.e. there is no API to tell us what the proc effect does. All we can do is parse the tooltip for "Equip: ..." text for words or patterns we know (such as "increases Intellect") but even those are incorrect most of the time.
The idea @Mirroar had for this problem was to allow the user to customize an item's stats, e.g. in this case, manually add "+7202 Health". This does not solve the detection problem, but unless we manually code in each and every proc effect with its stats, changes stats for upgrades, item quality upgrades etc. this will never be 100% accurate.
Blizzard simply does not offer any kind of API for this :(
ghost
TRIVIAL as people should not be using PVP trinkets, but question came up:
Heard from a Blood tank that the first trinket was coming up over the second.
[Primal Combatant's Insignia of Victory] +145 Versatility (1.12% @ L100) Equip: When you deal damage you have a chance to gain 505 Strength for 20 sec.
[Primal Combatant's Emblem of Tenacity] +171 Stamina Use: Increases maximum health by 7202 for 15 sec. Shares cooldown with other Battlemaster's trinkets. (2 Min Cooldown)
Does the "Adds health" proc get factored into the calculations? Doesn't look like the proc was getting factored in... Max Health, as a Tank, should basically be counted as "Adds 7202 health" -- whatever that is in Stamina -- 1/8th of the time.