MirrorNetworking / Mirror

#1 Open Source Unity Networking Library
https://mirror-networking.com
MIT License
5.25k stars 775 forks source link

can't handle the host being down because kcp transport swallows send errors #3906

Closed tycobbb closed 1 month ago

tycobbb commented 1 month ago

Describe the bug if you try to connect to a host that is down or unreachable, the kcp client spams error logs, does not attempt to disconnect, and provides no way to handle the error.

[IMPORTANT] How can we reproduce the issue, step by step: sorry, i haven't looked at your built-in examples but i imagine this is trivial to reproduce.

Expected behavior the client does not swallow errors (it swallows them on this line), and provides a way to handle the error so that it can be detected in user code and the player can be disconnected.

Screenshots none.

Desktop (please complete the following information):

Additional context none

tycobbb commented 1 month ago

wait this is not true, it just hits the timeout oops.