MirrorNetworking / Mirror

#1 Open Source Unity Networking Library
https://mirror-networking.com
MIT License
5.25k stars 775 forks source link

SyncList: keep old OnChange parameters to not break projects #3916

Closed miwarnec closed 1 month ago

miwarnec commented 1 month ago

we've had 10 years worth of projects hook into SyncLists for changes with (oldItem, newItem). reducing this to one parameter that is sometimes oldItem, sometimes newItem introduces too much pain when upgrading.

this will save people thousands of dollars in upgrade costs.

MrGadget1024 commented 1 month ago

You'll have to obsolete the current and fix all the tests to work for both.

I strongly disagree with this PR.

MrGadget1024 commented 1 month ago

Better to put Callback back in and not break everyone who has already adapted to OnChange and the new actions