Mirsario / Minecraft-CameraOverhaul

A Minecraft mod that makes gameplay more satisfying through the use of various camera tilting.
MIT License
37 stars 20 forks source link

Incompatible with Lunar Client #48

Open Uri1x opened 8 months ago

Uri1x commented 8 months ago

image

Uri1x commented 8 months ago

will the mod be updated anymore? its one of if not my favorite mod.

Mirsario commented 8 months ago

Yes, I'll look into this when I'm able.

Mirsario commented 7 months ago

What dependency versions are you using? MC 1.20.4, Cloth Config 13.0.0.121, Mod Menu 9.0.0 - work just fine. If you're using latest ones (for your MC version) - provide a latest.log after trying to access the config.

I'm thinking of rewriting the mod using preprocessor conditionals, the "version agnostic" implementation created more pain than it did good to players.

Uri1x commented 7 months ago

I'm using Lunar Client MC 1.20.4, Cloth Config 13.0.0.121, Mod Menu 9.0.0, and the issue persists. I'll send the screenshot and the log, but also I believe this might be an incompatibility with lunarclient's modloading support given it's in its early stages with phase 2 only recently being announced. Either way, I thank you for your help, and continued support of this mod. :)

image

Mirsario commented 7 months ago

It seems like Lunar is a deobfuscated release, which is problematic for my reflection code, which feeds intermediary names (net.minecraft.class_2561) into a mapping resolver and tries to use reflection access on the output of that. I'm not sure whether it's my mod's dependencies or lunar that should be shipping mapping files to resolve this. I'll just pursue an alternative design for the mod that I mentioned in the previous message, hopefully I don't lazy out five minutes in.

(Also, be careful with hashes on GitHub, they mention issues & PRs and create notifications for people involved in those.)

Uri1x commented 7 months ago

The issue im certain is most likely on lunars end since this occurs with other mods, and it may possibly or hopefully be fixed in phase two of their release, but either way goodluck with the alternate design, and thank you for your hard work and for the heads up. 👍