search

Mirsario / Minecraft-CameraOverhaul

A Minecraft mod that makes gameplay more satisfying through the use of various camera tilting.
MIT License
37 stars 20 forks source link

Update mixin and gradle. #55

Closed sam-mccarthy closed 2 months ago

sam-mccarthy commented 2 months ago

Instead of injecting into renderWorld, we can inject into bobView. This fixes both 1.20.6 and 1.21, and seems to work back to 1.16.4 (as far as my testing goes).

Mirsario commented 2 months ago

Thank you, but the Z-axis rotations applied in the new mixin do not seem to function on 1.20.6+ and 1.21, though they do on earlier versions. Perhaps the reflection-bloated RotateMatrixByAxis abstraction also broke? I have a preprocessor-based redesign of the mod in the works on the dev branch for a v2.0, but that's been taking far too long and had me get stuck with Gradle a few times. I'll check what's up by porting these changes there some time soon.

sam-mccarthy commented 2 months ago

I seem to have missed that in my testing because View Bobbing was turned on for me - if you turn it off, it disables the roll effect (because bobView is only run if it's enabled).

I just pushed a change that should fix this, by injecting into bob/tiltViewWhenHurt.

Mirsario commented 2 months ago

Whoops. Yes, I just had view bobbing enabled on one version range and not the other. Thanks again, merging & releasing.