1.4.4's Reworked Broadsword Issues

[RageTHD]

Swords with 1.4.4 slash effect doesn't use Overhaul's melee rework and act as vanilla weapon. Volcano uses Overhaul's melee rework swinging animations but uses vanilla hitboxes (you can see the particle effect from vanilla swing animations). Blade of Grass shoots a lot of leaves while using charge attack.

[NotNihilanth]

Rapidfire issue also observed on Waffle's Iron, so it's very likely related to the per-swing projectile firing behavior

[RageTHD]

To add to that, MoreZenithItems recently updated some of the weapons and Scythes that use 1.4.4 slash effect also don't work with Overhaul's melee rework. Before the update to MoreZenithItems Overhaul's melee worked like a charm.

[Mirsario]

Fixes TODO:

• [x] Fixed the Volcano, Blood Butcherer, and a few other melee weapons using incorrect rotations & locations for their particle effects.
• [x] Fixed Blade of Grass and projectile-only swords being able to create projectiles during a power attack charge.
• [x] Fixed the Volcano sword having broken collision checks.
• Projectile-only swords:
  • [x] Fixed the following projectile-only swords not getting the broadsword overhaul: Night's Edge, Excalibur, True Excalibur, True Night's Edge, Terra Blade, The Horseman's Blade.
  • [x] Fixed projectile-only swords not being fully aimable.
  • [x] Fixed projectile-only swords' swing trail projectiles not flipping with the player's swinging animation.
  • [ ] Fixed projectile-only swords not benefiting from velocity-based damage. (Commit above was misnamed, this isn't fixed.)
  • [ ] Fixed projectile-only swords not using mana when the Melee.EnableProjectileSwordManaUsage option is enabled.
    • [ ] Require and cost mana for the primary swing projectile.
  • [ ] Fixed projectile-only swords not being able to perform Killing Blows.
  • [ ] Fixed projectile-only swords not supporting air combat.
• [ ] MoreZenithItems mod tested and its swords have no issues.