search

MisaOgura / flashtorch

Visualization toolkit for neural networks in PyTorch! Demo -->
https://youtu.be/18Iw4qYqfPo
MIT License
734 stars 87 forks source link

open in colab badge #11

Closed vainaixr closed 5 years ago

vainaixr commented 5 years ago

for some reason it does not appear on my github, I edited only one badge, but it does not show on my github.

MisaOgura commented 5 years ago

Hi @vainaijr,

No worries, the notebook preview on GitHub doesn't often load.

As you can see below, for both activation_maximization_colab.ipynb and activation_maximization.ipynb, there are 2 badges:

Screen Shot 2019-09-19 at 15 00 42 Screen Shot 2019-09-19 at 15 00 48

My preference is to keep one which links to the notebook from this repo. i.e. https://colab.research.google.com/github/MisaOgura/flashtorch/blob/master/examples/activation_maximization_colab.ipynb.

Many thanks, Misa

vainaixr commented 5 years ago

I added only one badge, but it shows two, I raised an issue on colab

Screenshot (455) Screenshot (456)

it turns out that if I save it from colab, then open in colab badge gets added automatically, so no need to specify it once again, therefore, two badges were appearing.

MisaOgura commented 5 years ago

Hi @vainaijr,

Great, I can see that now the notebooks have one button.

One final request - can you change both links to https://colab.research.google.com/github/MisaOgura/flashtorch/blob/master/examples/activation_maximization_colab.ipynb, as the both links should redirect users to the colab version of the notebook on the master branch of this repository.

Many thanks, Misa

vainaixr commented 5 years ago

I had to edit through jupyter notebook, I think it will work now.

MisaOgura commented 5 years ago

All good @vainaijr, thanks for your contribution.