added all() method and some minor changes

Miserlou / NoDB

NoDB isn't a database.. but it sort of looks like one.

https://blog.zappa.io/posts/introducing-nodb-pythonic-data-store-s3

380 stars 45 forks source link

added all() method and some minor changes #12

Closed kecabojan closed 5 years ago

kecabojan commented 6 years ago

added all() method to retrieve all S3 objects. I think there is no point in using cache folder in this case.
moved 'bucket' to init method since it has to be set
removed region class variable since it's not used anywhere
added Moto lib to test_requirements for mocking boto3 api
added/modified tests

Miserlou commented 6 years ago

Tests are still failing, can you fix that? You might also want to look at the placebo library for replaying those boto calls like we do in Zappa.

antgel commented 5 years ago

@kecabojan @Miserlou Any news on this? If it's not implemented soon, we'll have to move to another backend for our use case. :( If it could be made to work quickly, we would be happy to fund development.

coveralls commented 5 years ago

Coverage increased (+15.5%) to 71.523% when pulling fc5e2871d6480da41ac584f2e496dd2f5ca9996b on kecabojan:master into ecb405ac31034145739f1753afe9482fb4d65a4f on Miserlou:master.

kecabojan commented 5 years ago

Tests are (finally) fixed. It is up to @Miserlou to merge or not. Thanks.

antgel commented 5 years ago

@kecabojan Wow, thanks! I'll try cherry-picking it in the meantime. :)