search

Miserlou / RJModules

Various modules for VCV Rack
https://github.com/Miserlou/RJModules
MIT License
98 stars 18 forks source link

RJModules (v0.5.0): voltages aren't compliant! #24

Open DomiKamu opened 6 years ago

DomiKamu commented 6 years ago

Hi,

I report you an issue about non-compliant voltages on outputs of some modules I've tested (Supersaw and BPM): these voltages are too high/over limits, regardling Eurorack Voltage Standards document, here:

This is applicable, for example, for Supersaw module: output is 0 to... around +22 V (when MIX knob is set at max - default - position).

Also, BPM should sends +10V, not +12V.

I don't have tested other modules yet, however.

Regards.

Miserlou commented 6 years ago

+1, Supersaw is definitely blown out. I didn't know what I was doing yet. Thanks for the report.

On Mon, Jan 29, 2018 at 9:02 AM, DomiKamu notifications@github.com wrote:

Hi,

I report you an issue about non-compliant voltages on outputs of some modules I've tested (Supersaw and BPM): these voltages are too high/over limits, regardling Eurorack Voltage Standards document, here: https://vcvrack.com/manual/VoltageStandards.html

This is applicable, for example, for Supersaw module: output is 0 to... around +22 V (when MIX knob is set at max - default - position).

Also, BPM should sends +10V, not +12V.

I don't have tested other modules yet, however.

Regards.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Miserlou/RJModules/issues/24, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIi01wxhUKBr5WmNsIcowdAfF6QebkLks5tPc9ygaJpZM4RwpDk .

DomiKamu commented 6 years ago

You're welcome! of course about Supersaw the "culprit" is the "OFFSET" switch (when on - default position). In case you'll plan updates (and only in this case) the best way, in my opinion, is to disable the OFFSET feature (always turned) off, by this way, voltages stay into -12 V ~+12 V range.

I'll study the source code ASAP.

DomiKamu commented 5 years ago

Hi (long time ago - 1 yr and half) I've seen you've started your plugin migration to Rack v1. For personal usage only, I've ported "Button" and "Buttons" only (custom RJModules plugin), so be careful, as indicated in VCV Rack Voltages, output voltages must stay in -11.7V ~ +11.7 V bounds. Best is +/- 10V. For now, both Button and Buttons modules send +12 V.

Regards. ;)

Miserlou commented 5 years ago

Hey Domi, you want to send a PR? Are you actually sending those values to real devices or something? I'm not sure why it really matters 11.7 vs 12 in a digital space, but I'm happy to accept any pull requests for your needs, I just don't get why it matters that much. :) But ok!