Miserlou / RJModules

Various modules for VCV Rack
https://github.com/Miserlou/RJModules
MIT License
99 stars 18 forks source link

Fails to compile #4

Open asbaklm opened 7 years ago

asbaklm commented 7 years ago

Hi there, thanks for these great modules. Current version fails to compile with the following error in Sidechain.cpp:

src/Sidechain.cpp: In member function ‘virtual void Sidechain::step()’: src/Sidechain.cpp:50:72: error: expected ‘)’ before numeric constant if(inputs[TRIGGER_INPUT].value > 0 || inputs[TRIGGER_INPUT].value 0){ ^ ../../compile.mk:53: recipe for target 'build/src/Sidechain.cpp.o' failed

davephillips commented 7 years ago

Looks like you're missing an operator before that last zero. An == sign maybe ?

Miserlou commented 7 years ago

Sorry, I forgot to commit the bugfix. Pushed now!

Are you compiling on OSX/Linux/Windows? I need somebody who has Windows to help me make a build so I can do a release.

I also need some help designing cross-architecture maintainable code..

jeremywen commented 7 years ago

I can help with a windows and/or mac build. Let me know.

Miserlou commented 7 years ago

I have a Mac, so I need help with the Linux and Windows builds. I can probably use Docker for the Linux builds no problem, but has anybody tried using MinGW for building Windows builds?

phdsg commented 7 years ago

ring me on irc. debian on my laptop and windows 7 on my desktop.

phdsg commented 7 years ago

here's a proactive build: zip contains both .so and .dll.

RJModules-dev-win_lin.zip

asbaklm commented 6 years ago

Thanks for the fix, I was compiling on Linux, compiles perfectly now. Thanks again, these modules look really nice.