search

Miserlou / SoundScrape

SoundCloud (and Bandcamp and Mixcloud) downloader in Python.
MIT License
1.42k stars 146 forks source link

Music keeps being redownloaded #185

Closed Starfox64 closed 4 years ago

Starfox64 commented 7 years ago

There is a specific music in my SoundCloud library that gets downloaded everytime I run soundscrape on my liked tracks.

Here is the music in question: https://soundcloud.com/ed-harrison/footprint

gamemasta0 commented 7 years ago

It appears that that's because it's a .wav file. I've made a pull request that includes code that fixes this problem. Prior to my changes, the code was only checking for .mp3 before determining whether or not to download/overwrite a file. I added a check for .wav. I've tested on my local copy and the track in question does not redownload with my changes. Here is the pull request I mentioned: https://github.com/Miserlou/SoundScrape/pull/179

SimplicityGuy commented 4 years ago

This issue is addressed in a future PR, after #241 is merged.