search

Miserlou / SoundScrape

SoundCloud (and Bandcamp and Mixcloud) downloader in Python.
MIT License
1.42k stars 146 forks source link

Early detection of wav or mp3 #213

Open ChristianKrausse opened 6 years ago

ChristianKrausse commented 6 years ago

soundscrape https://soundcloud.com/acidpauli/tracks Downloading: Jamie And Selda [################################] 70784/70784 - 00:00:23 Problem tagging file: Is this file a WAV?

Any sugestion how to go around this issue?

sorry, I saw it was a WAV File :/ ...

Is there a posibility to download reposts? Like: https://soundcloud.com/acidpauli/reposts

Lanchon commented 4 years ago 
Downloading: Jody Wisternoff ' Stories of Light ' Mix 1 - April 2020
[################################] 2511481/2511481 - 00:07:14
Problem tagging file: Is this file a WAV?

https://soundcloud.com/jodywisternoff/jody-wisternoff-stories-of-light-mix-1-april-2020

this happens when 1) track is downloadable, and 2) the downloadable format is WAV.

@Miserlou, is it possible to add an option to soundscrape such as:

  -D, --no-download   Scrape playback stream even for downloadable tracks.
  -s, --streaming     Scrape streaming data even for downloadable tracks.

this is a mediocre workaround for this issue i know, but it's very easy to implement and i always wanted it anyway for different reasons. i use soundscrape to sync my phone's local music lib. and i hate it when downloadable tracks end up being FLAC, WAV, etc. they use too much storage and the listening conditions don't justify much more than 128kb/s mp3.

SimplicityGuy commented 4 years ago

IIRC, the json response from SoundCloud where the track info is, it does indicate what type of file it is. That could be used to make a better determination of what to do with the file, rather than assuming it's an mp3 and renaming it to wav if it fails to tag.