Miserlou / SoundScrape

SoundCloud (and Bandcamp and Mixcloud) downloader in Python.
MIT License
1.42k stars 146 forks source link

Major update to version 1.0 #241

Open SimplicityGuy opened 4 years ago

SimplicityGuy commented 4 years ago

A bunch of major changes in this release!

Build/CI changes:

Breaking changes:

Fixes:

SimplicityGuy commented 4 years ago

@Miserlou bump. I'd like to get a second set of eyes on the changes here. I know it's a big change.

grea09 commented 4 years ago

It solved issues with filenames but broke the ability to download from likes apparently.

Here is an error on the UTF-8 test playlist I made:

$ soundscrape -f https://soundcloud.com/grea09/sets/utf8-test
...
Problem getting track data from: https://api.soundcloud.com/i1/tracks/Shogo Nomura'/streams/?client_id=OmTFHKYSMLFqnu2HHucmclAptedxWXkq&app_version=1481046241
Problem downloading すすめ!うちゅうひこうし
...

Here is the error with likes:

$ soundscrape -f https://soundcloud.com/grea09/likes
Problem getting track data from: https://api.soundcloud.com/i1/tracks/Expecting value: line 1 column 1 (char 0)/streams/?client_id=OmTFHKYSMLFqnu2HHucmclAptedxWXkq&app_version=1481046241

Thank you for the good work on the tool fixing those previous issues !

ldexterldesign commented 4 years ago

@SimplicityGuy 💋

Currently resorting to https://github.com/flyingrub/scdl but relieved to see this project is still going

Sincerely