2123 Fix `endpoint_url` when `use_apigateway` is false

Miserlou / Zappa

Serverless Python

https://blog.zappa.io/

MIT License

11.89k stars 1.2k forks source link

2123 Fix `endpoint_url` when `use_apigateway` is false #2124

Open jwilges opened 4 years ago

jwilges commented 4 years ago

Description

Update no longer raises an exception while updating endpoint_url with base_path when use_apigateway is False.

Further, when use_apigateway is False, update now also:

amends deployed_string with endpoint_url (admittedly, Zappa's formatting for this could be improved)
attempts to touch the endpoint based on Zappa's settings

GitHub Issues

See issue #2123 for more information and for further discussion.

jwilges commented 4 years ago

Hi @jneves, since you appear to be the sole life-blood for pull requests as of late, would you be able to take a look at this and let me know what you think?

I have deployed and tested this with our Lambdas by pinning:

"zappa@git+https://github.com/jwilges/Zappa@0.51.1.dev2"

I know this is probably annoying to check into, so I tried to provide a reasonable tag to pin and test against to make your life easier.

coveralls commented 4 years ago

Coverage increased (+0.1%) to 73.066% when pulling 1fed73376a14f1db8e9447346242085b455147d6 on jwilges:2123_fix_endpoint_url_when_use_apigateway_false into 93804a1b3157f0189bf062e01baab2bd4f09400d on Miserlou:master.