search

Miserlou / Zappa

Serverless Python
https://blog.zappa.io/
MIT License
11.89k stars 1.21k forks source link

Bump boto3/botocore versions #2193

Closed ian-whitestone closed 3 years ago

ian-whitestone commented 3 years ago

Description

In support of #2188, this PR bumps the versions of boto3/botocore, so that we have access to the new Docker image functionality.

GitHub Issues

Related #2188

Testing

I created a new virtual env with the new dependencies and ran several Zappa workflows: deploy, update, status, and undeploy.

image

image

Any other tests you'd recommend running?

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 72.975% when pulling d455069788465f2ee5ac805c65847ce25eb90f02 on ian-whitestone:bump-reqmts into 542c8c60291ebc5ece03b8dd4abe9e0172715086 on Miserlou:master.

ian-whitestone commented 3 years ago

Coverage Status

Coverage decreased (-16.6%) to 56.371% when pulling 6655776 on ian-whitestone:bump-reqmts into 542c8c6 on Miserlou:master.

No idea why coverage dropped, it shouldn't given that i just bumped dependencies. Can we merge even though this is failing (assuming we're ok with everything else?)

ian-whitestone commented 3 years ago

Coverage Status Coverage decreased (-16.6%) to 56.371% when pulling 6655776 on ian-whitestone:bump-reqmts into 542c8c6 on Miserlou:master.

No idea why coverage dropped, it shouldn't given that i just bumped dependencies. Can we merge even though this is failing (assuming we're ok with everything else?)

nvm, looks like it is passing now...

ian-whitestone commented 3 years ago

@jneves would you be able to 👍 or 👎 when you get a chance?

ian-whitestone commented 3 years ago

@mcrowson any chance you'd be able to 👍 or 👎 ?

mcrowson commented 3 years ago

I like the change, but can you make it to the zappa/zappa project? I'm not sure how @jneves pulled in the issues or if outstanding MRs got merged too, but make the changes to the other project and tag me.