fixes #6, error: illegal IP address string passed to inet_pton

Miserlou / django-easy-timezones

Easy timezones for Django based on GeoIP

http://gun.io/blog/django-easy-timezones/

Apache License 2.0

203 stars 44 forks source link

fixes #6, error: illegal IP address string passed to inet_pton #11

Closed vinitkumar closed 9 years ago

vinitkumar commented 9 years ago

The illegal IP usually comes up when the user is behind a proxy and gets comma separated values which might also have strings in it. We use this library in our project and faced this issue quite often. This fix works nicely for us and I hope for others too. Please take a look and merge if you are happy with the patch.

Thanks!

lucas03 commented 9 years ago

There is a different GEOIP database for IPv6 as far as I know - http://dev.maxmind.com/geoip/legacy/geolite/. I did not see it in your commit. Or am I wrong?

vinitkumar commented 9 years ago

@lucas03 you are right. I have not used the another database here and I was under the impression this same database has both ipv6 and ipv4 data. How do you suggest we take it forward?

lucas03 commented 9 years ago

well there are 3 pull (although mine is too sloppy) requests already. I hoped Miserlou would take care of this by now, because it is deal breaker for every IPv6 visitors or robots. https://github.com/Miserlou/django-easy-timezones/pull/9

pawciobiel commented 9 years ago

@Miserlou do you need anything else for this fix to be merged & released?

Miserlou commented 9 years ago

Looks okay, but honestly I haven't touched this code in a long time and the whole project needs some upgrades - test cases, coverage, etc.