MisfitMaid / tm-map-info

https://openplanet.dev/plugin/mapinfo
The Unlicense
0 stars 4 forks source link

"show in qualifier" shows when not really in qualifier #27

Open ezio416 opened 6 months ago

ezio416 commented 6 months ago

Feel free to close if there's no good solution. I notice this in at least 2 other plugins (including one of mine) where if you join the TOTD server shortly after qualifier ends, the gamemode is still TM_COTDQualifications_Online even though it's a lie. Maybe the time could be checked since qualifier only lasts 15 minutes but the server seems to stay in that mode for about 30.

Screenshot 2024-03-16 202727

XertroV commented 5 months ago

oh interesting. yeah odd edge case.

ezio416 commented 3 months ago

This can be resolved with MLFeed - only displaying when the gamemode matches and MLFeed::GetRaceData_V4().COTDQ_QualificationsProgress == MLFeed::QualificationStage::Running will do it. However I'm not sure adding the dependency is worth it just for this

XertroV commented 3 months ago

another way might be to look for both UI elements and decide based on which is visible