MishaKav / jest-coverage-comment

Comments a pull request or commit with the jest code coverage badge, full report and tests summary
MIT License
80 stars 34 forks source link

Using multiple-files in a monorepo setup logs a missing summary error in annotations #66

Closed 8lane closed 1 year ago

8lane commented 1 year ago

Issue

In our monorepo setup, we use the multiple-files argument to reference multiple json summary reports whilst omitting the coverage-summary-path argument. E.g.

            - name: Jest coverage comment
              uses: MishaKav/jest-coverage-comment@main
              with:
                  title: Jest Unit Test Coverage
                  multiple-files: |
                      ui, packages/ui/coverage/coverage-summary.json
                      bff, packages/bff/coverage/coverage-summary.json

In our workflow annotations, we get the following log:

Screenshot 2023-02-02 at 17 07 27

Solution

Suppress this log when multiple-files are included.

Happy to raise a PR for this :)

MishaKav commented 1 year ago

I believe the action works as expected, you just show a warning. Am I right?

8lane commented 1 year ago

I believe the action works as expected, you just show a warning. Am I right?

Yes exactly.

MishaKav commented 1 year ago

Thanks, I will fix it

MishaKav commented 1 year ago

Release a fix #68 for this, you can use:

- name: Jest coverage comment
  uses: MishaKav/jest-coverage-comment@main

or

- name: Jest coverage comment
  uses: MishaKav/jest-coverage-comment@v1.0.23