search

MishaKav / pytest-coverage-comment

Comments a pull request with the pytest code coverage badge and full report
MIT License
181 stars 60 forks source link

Adding in support for workflow_dispatch events #143

Closed alexjyong closed 1 year ago

alexjyong commented 1 year ago

This PR will allow this action to be used on workflow_dispatch events. The user will be required to pass a PR number via issue-number in the inputs, but this will allow folks to get coverage reports on demand in a github action instead of having to tie it to a pull-request/push event.

I needed this for a work project, so I figured I'd share this with everyone else!

MishaKav commented 1 year ago

great idea! I will take a look in the next few days and make a release for your new feature.

alexjyong commented 1 year ago

@MishaKav Thank you! Let me know if you need anything from me.

alexjyong commented 1 year ago

updated some merge conflicts that cropped up.

alexjyong commented 1 year ago

Ah I see this got folded in another PR. anything else needed from here or can we close this?

MishaKav commented 1 year ago

@alexjyong I tried to bump a new version and release your feature, but it can't build successfully, because you have Parsing error: Unexpected token else Can you please provide a fix for that? This is the branch with your changes https://github.com/MishaKav/pytest-coverage-comment/compare/support-pr-in-workflow-dispatch?expand=1 image

alexjyong commented 1 year ago

Sure thing.