Ranged weapons not applying DB

[feanix]

When using a ranged weapon, DB is not added when rolling damage

Description.

When using a ranged weapon, DB is not added when rolling damage. Melee weapons do this correctly.

Expected Behavior.

When rolling damage with a ranged weapon DB should be rolled as well, like melee weapons.

Actual Behavior.

When rolling damage with a ranged weapon DB is not rolled as well.

[kwitczak]

@snap01 I've taken a look into it and it seems that rollDamage() in rangecombat.js is adjusted mainly to firearms and mechanics of volleys. It would probably be easy to inject db there if it's defined on a weapon, but it seems a bit confusing to deal with db if you're reading logic of firearms.

My idea is to make rollDamage() pick on of these approaches based on the weapon properties:

• pick "current volley implementation" if the weapon is a firearm and doesn't care about the db modifier;
• pick a "simple range implementation" which includes a db modifier if the weapon is ranged (has range and any of db properties). Additionally, if I remember correctly, weapons which are marked as thrown should have a possible reaction of a player to make a dodge. Not sure if that applies to bows too, I'll need to check with a book.