Miskatonic-Investigative-Society / CoC7-FoundryVTT

An unofficial implementation of the Call of Cthulhu 7th Edition game system for Foundry Virtual Tabletop
https://discord.gg/foundryvtt
GNU General Public License v3.0
119 stars 98 forks source link

Add an option to choose an alternative Font for Sheets #1473

Open jeniankatarn opened 10 months ago

jeniankatarn commented 10 months ago

Description

I would like to have an option to change the font and its styling for all sheets (or individual sheets if easy to implement) from those that are available for the browser/system to use.

Context.

Current default (that I dug from browser using Web Developer Tools on Firefox:) is font-family: customSheetFont,Bradley Hand,cursive;. This font shows as really tiny squiggly cursive font that is hard to read at glance on my system (I specified this as none of my players are having this issue). Here is a screenshot of the font from player's character sheet. 2023-12-27_10-29

Instead of asking everyone to change from this stylistic choise, I'd appreciate for having the option to change the sheet font system wide or alternatively having an "easier to read" fallback font. I'm not sure if this issue comes from my machine not actually having that Bradley Hand font, not parsing it properly or my players' machines not having the font or not parsing it.

Having the option to choose the font or fallback font for the sheets would help those who have difficulties with pattern recognition, dyslexia or just hard time seeing small text. Small font is small even when zooming with browser's in built view but that in turn scales everything (tokens, map, interface etc.).

Possible Implementation.

I'm not a front-end developer nor have really good grasp of javascript/typescript so my suggestions are more thoughts than actual implementations recommendations:

snap01 commented 10 months ago

On a new world without modules enabled and the game settings for "Override Sheet Artwork" unticked (default) the character sheet should look like this image Are you able to create a new world without modules enabled and open the 1920 Character from the Examples Compendium Pack to see if this is a browser font selection issue or the font being replaced by a setting or module? A new design for the character sheet is in the works by it is currently not ready for implementation.

jeniankatarn commented 10 months ago

I made a test world without any additional modules loaded. Checked that the "Override Sheet Artwork" was unticked. Opened the 1920's Character sheet and here is the result: 2023-12-28_09-22

On a side note. When checking how the sheet element looks form the Web Developer Console and disabling this item: 2023-12-28_09-25 2023-12-28_09-26 The end result shows result "similar" to yours as it uses some Sans fallback. 2023-12-28_09-26_1

snap01 commented 10 months ago

Thank you for checking it appears the default cursive font is harder to read on non Windows devices at the sizes used.

snap01 commented 10 months ago