Development flag is attached before the roll results are displayed

[ryotai-trpg]

Prerequisites.

• [x] Have you checked the Upcoming Release section of the changelog to see if the issue will be resolved in the next release? https://github.com/Miskatonic-Investigative-Society/CoC7-FoundryVTT/blob/develop/.github/CHANGELOG.md
• [x] Are you running the latest version of both Foundry VTT and Call of Cthulhu 7th Edition?
• [x] Have you tested whether the bug persists without any other modules activated or on Foundry Launch in Safe Configuration?

Description.

When XP gain is on and "Display chat message immediately" option in the Dice So Nice module is disabled, the development flag is displayed before the role result is displayed and the success or failure of the skill is known.

Expected Behavior.

The development flag appear at the same time as chat cards.

Possible Fix.

Changing flagForDevelopement() in the link part of module/check.js as follows works pseudo. I'm a JavaScript newbie, so there must be a better way. https://github.com/Miskatonic-Investigative-Society/CoC7-FoundryVTT/blob/develop/module/check.js#L1423-L1426

before

  async flagForDevelopement () {
    this.flaggedForDevelopment = true
    if (this.skill) await this.skill.flagForDevelopement()
  }

after

  async flagForDevelopement () {
    if (game.modules.get('dice-so-nice')?.active && !game.settings.get("dice-so-nice", "immediatelyDisplayChatMessages")) {
      await new Promise(resolve => setTimeout(resolve, 2500))
    }
    this.flaggedForDevelopment = true
    if (this.skill) await this.skill.flagForDevelopement()
  }

[snap01]

This function is called from multiple places. A refactor of the check system is needed to call this function at a later point depending on method of showing the 3d dice. This will not be completed before the next release.