Emulator.get_command_line should throw exception and not return None

Miss-Inputs / Meow-Launcher

Game launcher type thing

Other

3 stars 0 forks source link

Emulator.get_command_line should throw exception and not return None #57

Closed Miss-Inputs closed 5 years ago

Miss-Inputs commented 6 years ago

Attempted to do this earlier, just need a way that makes sense with the additional case of "game file type / extension supported by emulator B but not A", and also "file in ROM folder is not a ROM file at all and hence supported by no emulator"

Miss-Inputs commented 5 years ago

I guess have the following exceptions for the varying use cases:

EmulationNotSupportedException NotAROMException (file type mismatch) NotAGameException (maybe better name? valid ROM file, but represents something that can't be launched, e.g. 3DS non-executable NCCH files)