search

MissCorruption / QuickLootIE

Attempt at porting QLEE to NG with i4 compat
MIT License
1 stars 3 forks source link

[FEATURE]: Renaming the SWF File #33

Open Wuerfelhusten opened 1 week ago

Wuerfelhusten commented 1 week ago

Feature Title

Renaming the SWF File

Motivation

There are several versions of Quickloot. The legacy version, Quickloot RE, Quieloot EE and now also Quickloot IE. All use the same interface file (at least in terms of name). This is not a bad thing in principle, but in plain language it also means that a NORDIC UI patch for Quickloot RE is installed by some inexperienced users via Quickloot IE. Unfortunately, this leads to unnecessary support cases and is somewhat confusing.

Feature Description

My suggestion here would be to rename the interface file to something else. This way no patch for another Quickloot version overwrites the interface of Quickloot IE and vice versa. This makes more than sense, especially with the upcoming major changes.

Additional Context

Credits for the idea: Rename Oxygenmeter.swf to OxygenMeter2.swf to avoid a downgrade by existing patches. image

AtomCrafty commented 1 week ago

That sounds like a good idea to me. It has the potential to avoid a lot of unnecessary confusion regarding old, incompatible reskins. We could even still check for the old file name and show a warning that it's incompatible.

Another option would be to add a version check to the swf so QLIE can just check which version the reskin was made for and whether it supports the latest features.

MissCorruption commented 1 week ago

Given that using an old Lootmenu might break things, I'd rename it personally. This is the simplest solution and probably the easiest to support, given my experience with end users and reading