MissionLifeline / afg

1 stars 0 forks source link

custom vertical layout renderer to display descriptions everywhere #34

Closed bastiion closed 2 years ago

bastiion commented 2 years ago

currently, it does not work for hidden elements as state change seems not to be detected

it is just a start to show how it can be done, markdown support comming soon.

Do not wonder about the coding style, it is almost directly taken from within the jsonforms project with some modifications, so I went with their way of coding.

astro commented 2 years ago

I am fighting with an infinite updating loop in this branch.

astro commented 2 years ago

33 needs to be merged first for the loop bug to be resolved.

astro commented 2 years ago

[x] Rebased on #33
[x] Description is now shown for visible elements even if they're date inputs
[ ] Not yet found a way for removing descriptions for JsonForms. They still show a duplicate description when focused. @bastiion to the rescue?

johannesloetzsch commented 2 years ago

[ ] Not yet found a way for removing descriptions for JsonForms. They still show a duplicate description when focused

A hack could be:

--- a/frontend/submission/styles/globals.scss
+++ b/frontend/submission/styles/globals.scss

+
+.MuiFormHelperText-root {
+  visibility: hidden;
+}

bastiion commented 2 years ago

[ ] Not yet found a way for removing descriptions for JsonForms. They still show a duplicate description when focused

A hack could be:
--- a/frontend/submission/styles/globals.scss
+++ b/frontend/submission/styles/globals.scss

+
+.MuiFormHelperText-root {
+  visibility: hidden;
+}

Almost @johannesloetzsch . This would disable all descriptions (also our descriptions). And why visibility: hidden? Do we need the spacing? We will probably use the following:

.MuiInput-root + .MuiFormHelperText-root {
  display: none;
}

this will only hide the siblings of the input element